[PATCH v2] staging: comedi: ni_mio_common: scale ao INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS

[Ian Abbott]

On 24/10/18 15:46, Spencer E. Olson wrote:
> Fixes implementation of INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS for
> ni_mio devices.  The previous patch should have used the channel
> information passed in to scale the result by the number of channels being
> used.
> 
> Fixes: 51fd36738383 ("staging: comedi: ni_mio_common: implement INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS")
> Signed-off-by: Spencer E. Olson <olsonse at umich.edu>
> ---
>   drivers/staging/comedi/drivers/ni_mio_common.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c b/drivers/staging/comedi/drivers/ni_mio_common.c
> index 2d1e0325d04d..5edf59ac6706 100644
> --- a/drivers/staging/comedi/drivers/ni_mio_common.c
> +++ b/drivers/staging/comedi/drivers/ni_mio_common.c
> @@ -2843,7 +2843,8 @@ static int ni_ao_insn_config(struct comedi_device *dev,
>   		return ni_ao_arm(dev, s);
>   	case INSN_CONFIG_GET_CMD_TIMING_CONSTRAINTS:
>   		/* we don't care about actual channels */
> -		data[1] = board->ao_speed;
> +		/* data[3] : chanlist_len */
> +		data[1] = board->ao_speed * data[3];
>   		data[2] = 0;
>   		return 0;
>   	default:
> 

Thanks.  Hopefully this and your other patch will make it into the next 
version of the kernel (4.20? 5.0?).  If not, they should be backported.

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott <abbotti at mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-