[PATCH] staging: android: ion: Fixed uninitialized heap name access

[Skidanov, Alexey]

> -----Original Message-----
> From: Dan Carpenter [mailto:dan.carpenter at oracle.com]
> Sent: Tuesday, October 23, 2018 08:33
> To: Skidanov, Alexey <alexey.skidanov at intel.com>
> Cc: Laura Abbott <labbott at redhat.com>; gregkh at linuxfoundation.org;
> devel at driverdev.osuosl.org
> Subject: Re: [PATCH] staging: android: ion: Fixed uninitialized heap name
> access
> 
> On Mon, Oct 22, 2018 at 05:47:08PM +0300, Alexey Skidanov wrote:
> >
> >
> > On 10/22/18 17:32, Laura Abbott wrote:
> > > On 10/22/2018 07:02 AM, Alexey Skidanov wrote:
> > >> The heap name might be uninitialized and access might crash the
> > >> kernel.
> > >>
> > >
> > > The heap name should never be null so this seems like this is being
> > > fixed in the wrong place. Can you explain more how you are hitting
> > > this issue?
> > Sure. Carve out heap name is uninitialized. There is the next patch
> > fixing it. But to be on the safe side, I have added the check.
> >
> 
> You keep saying uninitialized but you mean NULL.
I meant the uninitialized name, not the pointer. 
> 
> ion_carveout_heap_create() is never called so far as I can see so this
> isn't an issue in real life.  It feels like it would be detected right
ion_carveout_heap_create() is the only way to create this kind of heap. 
You are correct that currently it's never called - it's designed to be called by 
board specific code and in the meanwhile there is no standard way to do it. 
> away when that code was used.  We should just apply your follow on
> patch instead.
> 
> regards,
> dan carpenter
Thanks,
Alexey