[PATCH 5/5] Tools: hv: kvp: Fix a warning of buffer overflow with gcc 8.0.1
Greg KH
gregkh at linuxfoundation.org
Wed Oct 17 05:07:28 UTC 2018
On Wed, Oct 17, 2018 at 03:14:06AM +0000, kys at linuxonhyperv.com wrote:
> From: Dexuan Cui <decui at microsoft.com>
>
> The patch fixes:
>
> hv_kvp_daemon.c: In function 'kvp_set_ip_info':
> hv_kvp_daemon.c:1305:2: note: 'snprintf' output between 41 and 4136 bytes
> into a destination of size 4096
>
> Signed-off-by: Dexuan Cui <decui at microsoft.com>
> Cc: K. Y. Srinivasan <kys at microsoft.com>
> Cc: Haiyang Zhang <haiyangz at microsoft.com>
> Cc: Stephen Hemminger <sthemmin at microsoft.com>
> Cc: <Stable at vger.kernel.org>
> Signed-off-by: K. Y. Srinivasan <kys at microsoft.com>
> ---
> tools/hv/hv_kvp_daemon.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index bbb2a8ef367c..b7c2cf7eaba5 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1176,7 +1176,7 @@ static int kvp_set_ip_info(char *if_name, struct hv_kvp_ipaddr_value *new_val)
> int error = 0;
> char if_file[PATH_MAX];
> FILE *file;
> - char cmd[PATH_MAX];
> + char cmd[PATH_MAX * 2];
Overkill?
More information about the devel
mailing list