[PATCH 2/3] staging: rtl8188eu: cleanup array declaration - style

Joe Perches joe at perches.com
Thu Oct 4 18:10:57 UTC 2018

On Thu, 2018-10-04 at 14:12 +0200, Michael Straube wrote:
> On 10/3/18 11:30 PM, Joe Perches wrote:
> > >   static struct mlme_handler mlme_sta_tbl[] = {
> > 
> > Perhaps const here too, and as well, the struct
> > declaration could use const char * instead of char *
> > 
> Making it const gives following warning.
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c: In function 'mgt_dispatcher':
> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4114:9: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>    ptable = mlme_sta_tbl;

No worries, then it's not appropriate to use const.

It's just most common for this sort of table to be const
but if this driver is reassigning values in the table,
then it can't be const.

It is possible though that the code might not be suitable
for multiple simultaneous instances of the device type.

Dunno.  I don't use it nor have I inspected the code.

More information about the devel mailing list