[PATCH v3 00/29] staging: wilc1000: avoid static variables and cleanup changes

Dan Carpenter dan.carpenter at oracle.com
Mon Oct 1 07:47:34 UTC 2018


On Tue, Sep 25, 2018 at 11:53:15AM +0530, Ajay Singh wrote:
> This patch series contains changes to avoid the use of static variables.
> Cleanup changes to fix some checkpatch issues and return void for
> function if their return value is not used.
> Also deleted 'wilc_debugfs.c' file as it's not used.
> 
> Changes since v2:
>    Included Joe's suggestion for patch#28
>     - replaced previous patch with an improved version(refactor code)
> 
> Changes since v1:
>    Address Dan's comment for patch#29
>     - return the correct error for failure in the second iteration

Btw, I hate re-reviewing patches and I know everyone hates sending them.
If someone complains about a 28/29 or a 29/29, then you can just ask
Greg to apply the first 27 and redo the others in a follow on patchset.

regards,
dan carpenter




More information about the devel mailing list