[PATCH 00/16] staging: vchiq: dead code removal & misc fixes

Greg KH gregkh at linuxfoundation.org
Tue Nov 27 09:13:57 UTC 2018


On Mon, Nov 26, 2018 at 08:36:33PM +0100, Stefan Wahren wrote:
> > Nicolas Saenz Julienne <nsaenzjulienne at suse.de> hat am 20. November 2018 um 15:53 geschrieben:
> > 
> > 
> > Hi All,
> > 
> > This series was written in parallel with reading and understanding the
> > vchiq code. So excuse me for the lack of logic in the sequence of
> > patches.
> > 
> > The main focus was to delete as much code as possible, I've counted
> > around 550 lines, which is not bad. Apart from that there are some
> > patches enforcing proper kernel APIs usage.
> > 
> > The only patch that really changes code is the
> > vchiq_ioc_copy_element_data() rewrite.
> > 
> > The last commit updates the TODO list with some of my observations, I
> > realise some of the might be a little opinionated. If anything it's
> > going to force a discussion on the topic, which is nice.
> > 
> > It was developed on top of the latest linux-next, and was tested on a
> > RPIv3B+ with audio, video and running vchiq_test.
> > 
> > Regards,
> > Nicolas
> > 
> > RFC -> PATCH, as per Stefan's comments:
> >   - Remove semaphore initialization from remove_event_create()
> >     (commit 9)
> >   - Join all three semaphore to completion patches (commit 11)
> >   - Update probe/init commit message (commit 14)
> >   - Update TODO commit message and clean up (commit 16)
> >   - Fix spelling on some of the patches
> > 
> 
> The whole series is
> 
> Acked-by: Stefan Wahren <stefan.wahren at i2se.com>
> 
> Unfortunately patch 05 might not apply.

I fixed it up.

thanks,

greg k-h


More information about the devel mailing list