[PATCH v2 5/7] staging: mt7621-pci: avoid using clk_* operations

Sergio Paracuellos sergio.paracuellos at gmail.com
Mon Nov 26 19:48:09 UTC 2018


On Mon, Nov 26, 2018 at 11:01 AM Dan Carpenter <dan.carpenter at oracle.com> wrote:
>
> On Sat, Nov 24, 2018 at 06:54:55PM +0100, Sergio Paracuellos wrote:
> > There is no clock driver for ralink mips and clk_enable
> > are no-ops for this architecture. This has been also tested
> > without using clocks and seems to work so avoid to use them
> > in this driver.
> >
> > Fixes: ad9c87e129d1: "staging: mt7621-pci: parse and init
> > port data from device tree"
> > Reported-by: NeilBrown <neil at brown.name>
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos at gmail.com>
>
> This is fine, but in the future just let the Fixes tag go over the 75
> character limit without wrapping it.  checkpatch.pl shouldn't complain.
>
> Also you don't need to put a blank line between the Reported-by and the
> S-o-b.

Thanks for advices, Dan.
I'll take those into account from know.

>
> regards,
> dan carpenter
>
Best regards,
    Sergio Paracuellos


More information about the devel mailing list