[PATCH] staging: Remove the mt29f_spinand driver

Greg Kroah-Hartman gregkh at linuxfoundation.org
Mon Nov 5 14:34:33 UTC 2018


On Mon, Nov 05, 2018 at 03:27:34PM +0100, Miquel Raynal wrote:
> Hi Greg,
> 
> Greg Kroah-Hartman <gregkh at linuxfoundation.org> wrote on Mon, 5 Nov
> 2018 14:29:49 +0100:
> 
> > On Mon, Nov 05, 2018 at 11:12:27AM +0100, Miquel Raynal wrote:
> > > Hi Greg,
> > > 
> > > Boris Brezillon <boris.brezillon at bootlin.com> wrote on Mon, 22 Oct 2018
> > > 22:10:59 +0200:
> > >   
> > > > A new SPI NAND subsystem has been added in drivers/mtd/nand/spi/ and
> > > > Micron's MT29F devices are now supported in
> > > > drivers/mtd/nand/spi/micron.c.
> > > > 
> > > > Remove the old driver.
> > > > 
> > > > Signed-off-by: Boris Brezillon <boris.brezillon at bootlin.com>
> > > > ---
> > > > Hello,
> > > > 
> > > > If anything is missing in drivers/mtd/nand/spi/micron.c to properly
> > > > support the devices supported by the mt29f_spinand driver, please let
> > > > me know.
> > > > I might accept to delay removal of this driver if I have some guarantees
> > > > that existing users will actually switch to the new driver at some
> > > > point.
> > > > 
> > > > Regards,
> > > > 
> > > > Boris
> > > > ---  
> > > 
> > > I plan to apply this patch but I would like your approval first.
> > > 
> > > As a summary, the mt29f_spinand driver is a Micron SPI NAND chip
> > > driver interfacing with the raw NAND API (which is 'wrong').
> > > 
> > > Boris has recently contributed a SPI NAND framework supporting SPI
> > > NAND chips from several vendors, including Micron, that is supposed to
> > > take over this driver.
> > > 
> > > Do you see anything that should prevent us to remove it now?  
> > 
> > Not at all, I was going to add this patch to my tree right now, as I
> > couldn't do anything until after 4.20-rc1 was out.  Any objection from
> > me just taking it that way and getting it into 4.20-final?
> 
> I'm fine with you taking it but I have changes in the pipe that are
> impacted by this removal so it would be great if this could happen
> pretty early in the 4.20 release cycle (4.20-rc2?), so I will still be
> able to base nand/next on top of it.

If you need to work on top of this, please take it through your tree and
feel free to add:

Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

That way I'm not holding up any work from anyone else.

thanks,

greg k-h


More information about the devel mailing list