[PATCH net-next 6/7] net: bridge: Notify about bridge VLANs

Petr Machata petrm at mellanox.com
Fri May 25 17:00:37 UTC 2018


Vivien Didelot <vivien.didelot at savoirfairelinux.com> writes:

>> +	} else {
>> +		err = br_switchdev_port_obj_add(dev, v->vid, flags);
>> +		if (err && err != -EOPNOTSUPP)
>> +			goto out;
>>  	}
>
> Except that br_switchdev_port_obj_add taking vid and flags arguments
> seems confusing to me, the change looks good:

I'm not sure what you're aiming at. Both VID and flags are sent with the
notification, so they need to be passed on to the function somehow. Do
you have a counterproposal for the API?

Thanks,
Petr


More information about the devel mailing list