[PATCH] Delete the goldfish_nand driver.

Greg KH gregkh at linuxfoundation.org
Wed May 16 18:24:40 UTC 2018


On Wed, May 16, 2018 at 10:31:26AM -0700, Roman Kiryanov wrote:
> Hi, thank you for looking.
> 
> I see goldfish_audio.c in drivers/staging/goldfish. There
> is arch/mips/configs/generic/board-ranchu.config referencing this driver
> (CONFIG_GOLDFISH_AUDIO=y). I believe we need to keep goldfish to keep this
> config.

Does anyone actually use that config?  Is it a "real" device?

> I can move the goldfish folder to a more appropriate place and add more
> goldfish drivers there. Will drivers/goldfish work for you?

It has a long effort to be cleaned up properly before it can get out of
drivers/staging/, it's not a matter of just moving it to a new
directory.  It is in staging for a good reason :)

Again, are these even needed now that the cuttlefish build target is
present?  Who is even using these drivers?  Why has no one worked on
cleaning up the upstream code in the past few years?

thanks,

greg k-h


More information about the devel mailing list