[PATCH v2 5/5] staging: mt7621-gpio: update TODO file
Sergio Paracuellos
sergio.paracuellos at gmail.com
Tue May 15 08:23:53 UTC 2018
On Tue, May 15, 2018 at 09:29:04AM +0200, Greg KH wrote:
> On Tue, May 15, 2018 at 06:49:57AM +0200, Sergio Paracuellos wrote:
> > This commit updates TODO file with missing things to
> > get this driver ready to be mainlined.
> >
> > Signed-off-by: Sergio Paracuellos <sergio.paracuellos at gmail.com>
> > Reviewed-by: NeilBrown <neil at brown.name>
> > ---
> > drivers/staging/mt7621-gpio/TODO | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/staging/mt7621-gpio/TODO b/drivers/staging/mt7621-gpio/TODO
> > index 7143905..54e6271 100644
> > --- a/drivers/staging/mt7621-gpio/TODO
> > +++ b/drivers/staging/mt7621-gpio/TODO
> > @@ -1,5 +1,6 @@
> >
> > -- general code review and clean up
> > +- general code review and clean up: avoid global variables and use drvdata allocated instead
>
> This now goes beyond 80 columns so someone else will send a patch fixing
> that up :)
>
> How about making this two lines instead please.
Ack! I'll include this in my next series.
>
> thanks,
>
> greg k-h
Best regards,
Sergio Paracuellos
More information about the devel
mailing list