[PATCH 01/28] staging: most: allocate only all requested memory

[Christian Gromm]

On 09.05.2018 16:54, Dan Carpenter wrote:
> On Wed, May 09, 2018 at 04:09:21PM +0200, Christian Gromm wrote:
>> On 09.05.2018 15:19, Dan Carpenter wrote:
>>> On Tue, May 08, 2018 at 11:44:49AM +0200, Christian Gromm wrote:
>>>> This prohibits the allocation of the memory for the MBOs if only the
>>>> part of the MBOs, requested by the application, may be allocated.  The
>>>> function arm_mbo_chain, if cannot allocate all requested MBO, frees all
>>>> prior allocated memory and returns 0.
>>>>
>>>> Signed-off-by: Andrey Shvetsov <andrey.shvetsov at k2l.de>
>>>> Signed-off-by: Christian Gromm <christian.gromm at microchip.com>
>>>
>>> I don't understand how Andrey is involved with this code.  Did he write
>>> it?  Why isn't he on the CC list?
>>
>> Andrey and I are writing the code for this driver and our internal dev
>> process on Gitlab is based on reviews.
>> Which means that everything I push needs to be reviewed by Andrey and
>> vice versa before it gets merged to master. Then I have to do the
>> upstream work.
>>
>> I didn't put him on CC explicitly, because git-sendemail does it,
>> doesn't it?
> 
> It didn't CC him so far as I can see...  BCC?

Hmm, I'll make sure that he'll be put on CC next time.

> 
> Signed-of-by basically means you handled the code but didn't secretly
> insert any of SCO's top secret UNIX code into the patch.  It's sort of
> a legal thing.

To be honest, I don't pay much attention to the order of those tags.

> 
> It sort of sounds like Andrey is reviewing your code?  In that case,
> probably Reviewed-by is the correct tag.

Yes. We are basically sitting in the same building and talk things
through, before merging them. I'll suggest your proposal.

thanks,
Chris

> 
> Normally the tags are sort of in chronoligical order.
> 
> Reported-by: Sally
> Signed-off-by: Bob
> Reviewed-by: Mary
> Signed-off-by: Subsystem Maintainer
> 
> So it always confuses me when the first person to Sign off isn't the
> author.
> 
> regards,
> dan carpenter
>