[PATCH v3 2/6] staging: ks7010: remove some dead code from ks_wlan_set_essid function
Greg KH
gregkh at linuxfoundation.org
Wed Mar 28 11:51:39 UTC 2018
On Mon, Mar 26, 2018 at 06:52:48PM +0200, Sergio Paracuellos wrote:
> This commit removes death code which is not being used at all because
> it is inside a preprocessor if 0 directive. This change improves a bit
> readability of ks_wlan_set_essid function.
That's not what your patch does:
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos at gmail.com>
> ---
> drivers/staging/ks7010/ks_wlan_net.c | 15 ---------------
> 1 file changed, 15 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks_wlan_net.c b/drivers/staging/ks7010/ks_wlan_net.c
> index 6106e79..4019f3a 100644
> --- a/drivers/staging/ks7010/ks_wlan_net.c
> +++ b/drivers/staging/ks7010/ks_wlan_net.c
> @@ -276,7 +276,6 @@ static int ks_wlan_set_essid(struct net_device *dev,
> memset(priv->reg.ssid.body, 0, sizeof(priv->reg.ssid.body));
> priv->reg.ssid.size = 0;
> } else {
> -#if 1
It has a #if 1, not "0" :(
Being specific is good...
thanks,
greg k-h
More information about the devel
mailing list