[PATCH 4/7] staging: mt7621-dma: Remove assignment in if

Christian Lütke-Stetzkamp christian at lkamp.de
Wed Mar 21 20:23:59 UTC 2018


On Wed, Mar 21, 2018 at 09:21:55AM +1100, NeilBrown wrote:
> I don't like this change.  We now call vchan_find_desc() in situations
> where we didn't before.  It isn't a very expensive function so that
> doesn't matter a lot, but I think it is best not to do this.
> If you want to remove the warning (and I'm not convinced that we need
> to), please make it.
> 
>   ....
>   } else {
>       vdesc = vchan_find_desc(...);
>       if (vdesec)
>           state->residue = ...
>  }

Thank you for your reviewing all the patches. I'will change this patch
based on your advice and send a v2.

Christian


More information about the devel mailing list