[PATCH 7/7] staging:iio:ade7854: Add proper error handling condition

Dan Carpenter dan.carpenter at oracle.com
Fri Mar 16 08:02:57 UTC 2018


You're right that there is a bug but this is not the right fix.

The ade7854_i2c_write_reg_32() function returns 6 on success which makes
no sense.  It should be zero or negative error codes.  All the write_reg
functions in drivers/staging/iio/meter/ade7854-i2c.c have the same bug.

Please, fix that instead and leave ade7854_initial_setup() alone.

regards,
dan carpenter



More information about the devel mailing list