[PATCH 1/3] staging: ks7010: remove useless DPRINTK traces

Dan Carpenter dan.carpenter at oracle.com
Wed Mar 14 08:13:54 UTC 2018


On Tue, Mar 13, 2018 at 05:55:20PM +0100, Sergio Paracuellos wrote:
> @@ -786,14 +723,6 @@ void hostif_connect_indication(struct ks_wlan_private *priv)
>  
>  	switch (connect_code) {
>  	case RESULT_CONNECT:	/* connect */
> -		DPRINTK(3, "connect :: scan_ind_count=%d\n",
> -			priv->scan_ind_count);
> -		if (!(priv->connect_status & FORCE_DISCONNECT))
> -			netif_carrier_on(netdev);
> -		tmp = FORCE_DISCONNECT & priv->connect_status;
> -		priv->connect_status = tmp + CONNECT_STATUS;
> -		break;
> -	case RESULT_DISCONNECT:	/* disconnect */
>  		DPRINTK(3, "disconnect :: scan_ind_count=%d\n",
>  			priv->scan_ind_count);
>  		netif_carrier_off(netdev);

I was on board until this chunk.  You got a bit carried away.

regards,
dan carpenter



More information about the devel mailing list