[PATCH v2] staging: vchiq_arm: Clear VLA warning
Tobin C. Harding
me at tobin.cc
Mon Mar 12 05:46:13 UTC 2018
On Mon, Mar 12, 2018 at 12:37:53PM +1100, Tobin C. Harding wrote:
> The kernel would like to have all stack VLA usage removed[1]. The array
> here is fixed (declared with a const variable) but it appears like a VLA
> to the compiler. Also, currently we are putting 768 bytes on the
> stack. This function is only called on the error path so performance is
> not critical, let's just allocate the memory instead of using the
> stack. This saves stack space and removes the VLA build warning.
>
> kmalloc a buffer for dumping state instead of using the stack.
>
> [1]: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Tobin C. Harding <me at tobin.cc>
> ---
Drop this please, leaks memory.
thanks,
Tobin.
More information about the devel
mailing list