[PATCH v2 1/3] staging: xm2mvscale: Driver support for Xilinx M2M Video Scaler

[Hans Verkuil]

On 22/02/18 14:46, Greg KH wrote:
> On Wed, Feb 21, 2018 at 02:43:14PM -0800, Rohit Athavale wrote:
>> This commit adds driver support for the pre-release Xilinx M2M Video
>> Scaler IP. There are three parts to this driver :
>>
>>  - The Hardware/IP layer that reads and writes register of the IP
>>    contained in the scaler_hw_xm2m.c
>>  - The set of ioctls that applications would need to know contained
>>    in ioctl_xm2mvsc.h
>>  - The char driver that consumes the IP layer in xm2m_vscale.c
>>
>> Signed-off-by: Rohit Athavale <rohit.athavale at xilinx.com>
>> ---
> 
> I need an ack from the linux-media maintainers before I can consider
> this for staging, as this really looks like an "odd" video driver...

This should definitely use the V4L2 API. I guess it could be added
to staging/media with a big fat TODO that this should be converted to
the V4L2 mem2mem framework.

But it makes no sense to re-invent the V4L2 streaming API :-)

drivers/media/platform/mx2_emmaprp.c does something similar to this.
It's a little bit outdated (not using the latest m2m helper functions)
but it is a good starting point.

So for this series:

Nacked-by: Hans Verkuil <hans.verkuil at cisco.com>

If this was added to drivers/staging/media instead and with an updated
TODO, then we can accept it, but we need to see some real effort afterwards
to switch this to the right API. Otherwise it will be removed again
after a few kernel cycles.

Regards,

	Hans