[PATCH v2 1/2] gpio: mediatek: add driver for MT7621

Dan Carpenter dan.carpenter at oracle.com
Fri Jun 29 13:31:35 UTC 2018


Looks pretty clean to me.  Sorry for not reviewing v1.  Smatch (private
devel version) points out a little bit of dead code.

drivers/staging/mt7621-gpio/gpio-mt7621.c:200 mediatek_gpio_irq_handler() warn: address of 'gpio_data->gc_map[i]' is non-NULL
drivers/staging/mt7621-gpio/gpio-mt7621.c:225 mediatek_gpio_irq_unmask() warn: address of 'gpio_data->gc_map[bank]' is non-NULL
drivers/staging/mt7621-gpio/gpio-mt7621.c:246 mediatek_gpio_irq_mask() warn: address of 'gpio_data->gc_map[bank]' is non-NULL
drivers/staging/mt7621-gpio/gpio-mt7621.c:266 mediatek_gpio_irq_type() warn: address of 'gpio_data->gc_map[bank]' is non-NULL

But that's harmless and very minor.

regards,
dan carpenter



More information about the devel mailing list