[PATCH 2/2] staging: goldfish: cleanup in goldfish_audio

Greg KH gregkh at linuxfoundation.org
Fri Jun 29 07:38:58 UTC 2018


On Thu, Jun 28, 2018 at 06:19:14PM -0700, rkir at google.com wrote:
> From: Roman Kiryanov <rkir at google.com>
> 
> * added a mutex to protect open/read/write/release calls;
> * put the global atomic counter for opened files into the
>     driver state;
> * retired the global variable for the driver state;
> * retired the ioctl calls because it does not do much and cmd=315
>     looks obsolete.

When you have to provide a list of things you are doing in a single
patch, that is a huge hint you need to split that patch up into smaller
pieces.  Each of these bullets should be a single patch.

thanks,

greg k-h


More information about the devel mailing list