[PATCH 2/2] staging: goldfish: Add goldfish sync driver

Greg KH gregkh at linuxfoundation.org
Thu Jun 28 13:42:03 UTC 2018


On Wed, Jun 27, 2018 at 02:50:52PM -0700, rkir at google.com wrote:
> From: Roman Kiryanov <rkir at google.com>
> 
> This is kernel driver for controlling the Goldfish sync
> device on the host. It is used to maintain ordering
> in critical OpenGL state changes while using
> GPU emulation.

Why are you adding new features and drivers and not spending the time to
get the existing code cleaned up and out of the staging tree?  Please
work on that, I don't want to keep taking new code without any time
being spent on the existing stuff.

Staging is not a dumping ground, work needs to be done on the code in it
to get it out of the tree.  If that doesn't happen, I will remove it.

Also, this code causes a bunch of build warnings, I could not take it
anyway.  Please be more careful in the future.

thanks,

greg k-h


More information about the devel mailing list