[PATCH 2/2] staging: goldfish: Add goldfish sync driver
kbuild test robot
lkp at intel.com
Thu Jun 28 00:14:05 UTC 2018
Hi Roman,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on staging/staging-testing]
[also build test WARNING on v4.18-rc2 next-20180627]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/rkir-google-com/goldfish-Add-functions-to-simplify-goldfish-related-MMIO/20180628-055436
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/staging/goldfish/goldfish_sync_timeline.c: In function 'run_command_locked':
>> drivers/staging/goldfish/goldfish_sync_timeline.c:564:11: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
(u64)timeline,
^
>> drivers/staging/goldfish/goldfish_sync_timeline.c:574:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(struct goldfish_sync_timeline_obj *)
^
drivers/staging/goldfish/goldfish_sync_timeline.c:594:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(struct goldfish_sync_timeline_obj *)
^
drivers/staging/goldfish/goldfish_sync_timeline.c:607:5: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
(struct goldfish_sync_timeline_obj *)
^
drivers/staging/goldfish/goldfish_sync_timeline.c: In function 'goldfish_sync_ioctl':
drivers/staging/goldfish/goldfish_sync_timeline.c:800:6: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
(u64)timeline);
^
vim +564 drivers/staging/goldfish/goldfish_sync_timeline.c
548
549 void run_command_locked(const struct goldfish_sync_hostcmd *todo,
550 struct goldfish_sync_state *sync_state)
551 {
552 switch (todo->cmd) {
553 case CMD_SYNC_READY:
554 break;
555
556 case CMD_CREATE_SYNC_TIMELINE:
557 dev_info(sync_state->dev, "CMD_CREATE_SYNC_TIMELINE\n");
558 {
559 struct goldfish_sync_timeline_obj *timeline =
560 goldfish_sync_timeline_create(sync_state);
561
562 goldfish_sync_hostcmd_reply(sync_state,
563 CMD_CREATE_SYNC_TIMELINE,
> 564 (u64)timeline,
565 0,
566 todo->hostcmd_handle);
567 }
568 break;
569
570 case CMD_CREATE_SYNC_FENCE:
571 dev_info(sync_state->dev, "CMD_CREATE_SYNC_FENCE\n");
572 {
573 struct goldfish_sync_timeline_obj *timeline =
> 574 (struct goldfish_sync_timeline_obj *)
575 todo->handle;
576
577 int sync_fence_fd =
578 goldfish_sync_fence_create(sync_state,
579 timeline,
580 todo->time_arg);
581
582 goldfish_sync_hostcmd_reply(sync_state,
583 CMD_CREATE_SYNC_FENCE,
584 sync_fence_fd,
585 0,
586 todo->hostcmd_handle);
587 }
588 break;
589
590 case CMD_SYNC_TIMELINE_INC:
591 dev_info(sync_state->dev, "CMD_SYNC_TIMELINE_INC\n");
592 {
593 struct goldfish_sync_timeline_obj *timeline =
594 (struct goldfish_sync_timeline_obj *)
595 todo->handle;
596
597 goldfish_sync_timeline_inc(sync_state,
598 timeline,
599 todo->time_arg);
600 }
601 break;
602
603 case CMD_DESTROY_SYNC_TIMELINE:
604 dev_info(sync_state->dev, "CMD_DESTROY_SYNC_TIMELINE\n");
605 {
606 struct goldfish_sync_timeline_obj *timeline =
607 (struct goldfish_sync_timeline_obj *)
608 todo->handle;
609
610 goldfish_sync_timeline_destroy(sync_state, timeline);
611 }
612 break;
613
614 default:
615 dev_err(sync_state->dev, "Unexpected command: %u\n", todo->cmd);
616 break;
617 }
618
619 dev_info(sync_state->dev, "Done executing sync command\n");
620 }
621
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 64115 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180628/af254791/attachment-0001.bin>
More information about the devel
mailing list