[PATCH] staging: rtl8723bs: fix brace coding style issues
Dan Carpenter
dan.carpenter at oracle.com
Sat Jun 23 08:40:18 UTC 2018
On Fri, Jun 22, 2018 at 03:27:46PM +0200, Michael Straube wrote:
> On 06/22/18 12:28, Dan Carpenter wrote:
> > > if (count < 1)
> > > return -EFAULT;
> > > - if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp))) {
> > > + if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp)))
> > > sscanf(tmp, "%u", &g_wait_hiq_empty);
> > > - }
> >
> >
> > The original code is kind of bad. The NULL check isn't required.
>
> Just for clarification, NULL check refers to checking if buffer != NULL in the
> if condition?
>
> if (buffer && !copy_from_user(tmp, buffer, sizeof(tmp)))
> ~~~~~~
Yes. If buffer is NULL that's just another invalid pointer which the
user cannot access, it's not special, and the copy will fail.
regards,
dan carpenter
More information about the devel
mailing list