[PATCH v3 5/5] staging: use BIT_ULL for NL80211_STA_INFO_* attribute types

Kalle Valo kvalo at codeaurora.org
Mon Jun 18 07:29:43 UTC 2018


Greg KH <greg at kroah.com> writes:

> On Sun, Jun 17, 2018 at 01:07:36PM +0300, Omer Efrat wrote:
>> The BIT macro uses unsigned long which some architectures handle as 32 bit
>> and therefore might cause macro's shift to overflow when used on a value
>> equals or larger than 32 (NL80211_STA_INFO_RX_DURATION and afterwards).
>> 
>> Since 'filled' member in station_info changed to u64, BIT_ULL macro
>> should be used with all NL80211_STA_INFO_* attribute types instead of BIT
>> to prevent future possible bugs when one will use BIT macro for higher
>> attributes by mistake.
>> 
>> This commit cleans up all usages of BIT macro with the above field
>> in cfg80211 by changing it to BIT_ULL instead.
>> 
>> Signed-off-by: Omer Efrat <omer.efrat at tandemg.com>
>
> Acked-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Via which tree is this supposed to go?

-- 
Kalle Valo


More information about the devel mailing list