[PATCH 1/3] staging: hwmon: Fix SPACING errors
Guenter Roeck
linux at roeck-us.net
Tue Jun 12 20:21:07 UTC 2018
On Tue, Jun 12, 2018 at 08:56:58PM +0200, Jakob Albert wrote:
> Fix SPACING errors in drivers/hwmon/nct7904.c reported by checkpatch.pl
>
Subject for all patches in this series should be
hwmon: (nct7904) <Summary>
There is no need to reference the file name in the patch description.
It is obvious from both Subject and the patch itself.
linux-hwmon at vger.kernel.org needs to be in Cc:.
As Greg already mentioned, this series has nothing to do with staging.
Thanks,
Guenter
> Signed-off-by: Lorenz Kaestle <lorenz.kaestle at fau.de>
> Signed-off-by: Jakob Albert <jakob.j.albert at fau.de>
> ---
> drivers/hwmon/nct7904.c | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/hwmon/nct7904.c b/drivers/hwmon/nct7904.c
> index 95a68ab..7de2421 100644
> --- a/drivers/hwmon/nct7904.c
> +++ b/drivers/hwmon/nct7904.c
> @@ -159,7 +159,7 @@ static int nct7904_read_fan(struct device *dev, u32 attr, int channel,
> unsigned int cnt, rpm;
> int ret;
>
> - switch(attr) {
> + switch (attr) {
> case hwmon_fan_input:
> ret = nct7904_read_reg16(data, BANK_0,
> FANIN1_HV_REG + channel * 2);
> @@ -200,7 +200,7 @@ static int nct7904_read_in(struct device *dev, u32 attr, int channel,
>
> index = nct7904_chan_to_index[channel];
>
> - switch(attr) {
> + switch (attr) {
> case hwmon_in_input:
> ret = nct7904_read_reg16(data, BANK_0,
> VSEN1_HV_REG + index * 2);
> @@ -236,7 +236,7 @@ static int nct7904_read_temp(struct device *dev, u32 attr, int channel,
> struct nct7904_data *data = dev_get_drvdata(dev);
> int ret, temp;
>
> - switch(attr) {
> + switch (attr) {
> case hwmon_temp_input:
> if (channel == 0)
> ret = nct7904_read_reg16(data, BANK_0, LTD_HV_REG);
> @@ -276,7 +276,7 @@ static int nct7904_read_pwm(struct device *dev, u32 attr, int channel,
> struct nct7904_data *data = dev_get_drvdata(dev);
> int ret;
>
> - switch(attr) {
> + switch (attr) {
> case hwmon_pwm_input:
> ret = nct7904_read_reg(data, BANK_3, FANCTL1_OUT_REG + channel);
> if (ret < 0)
> @@ -301,7 +301,7 @@ static int nct7904_write_pwm(struct device *dev, u32 attr, int channel,
> struct nct7904_data *data = dev_get_drvdata(dev);
> int ret;
>
> - switch(attr) {
> + switch (attr) {
> case hwmon_pwm_input:
> if (val < 0 || val > 255)
> return -EINVAL;
> @@ -322,7 +322,7 @@ static int nct7904_write_pwm(struct device *dev, u32 attr, int channel,
>
> static umode_t nct7904_pwm_is_visible(const void *_data, u32 attr, int channel)
> {
> - switch(attr) {
> + switch (attr) {
> case hwmon_pwm_input:
> case hwmon_pwm_enable:
> return S_IRUGO | S_IWUSR;
> --
> 2.7.4
>
More information about the devel
mailing list