[PATCH v3 0/8] staging: mt7621-gpio: last cleanups
Sergio Paracuellos
sergio.paracuellos at gmail.com
Mon Jun 11 09:56:33 UTC 2018
After submiting this driver to try to get mainlined and get
out of staging some new cleanups seems to be necessary.
According to this main of Linus Walleij:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-June/121742.html
this series tries to fix all of the issues in order to send
v2 and give it a new try. Because I don't have to hardware to
test my changes I send new cleanups first in staging to make
easier to NeilBrown test it and get a feedback about them.
Changes in v3:
- PATCH 7: refactor irq_type to make better code.
- Add PATCH 8 avoiding the use of custom domain and requesting
manually a 'IRQF_SHARED'. It should be working now??
Changes in v2:
- Patch where GPIOLIB_IRQCHIP was used avoiding
the use of a custom irq domain has been dropped to
be sure after this changes all is working properly.
(This was PATCH 7 in previous series)
- PATCH 1:
* avoid introducing new macros and use 'bank'
field of mtk_gc with register offset.
* Make correct use of bgpio_init passing new
void __iomem pointers instead of use the
macros.
- Previous series PATCH 8 now is PATCH 7. Avoid the
use of a switch-case statement which was wrong and
distinc if we have RISSING AND FALLING EDGE interrupt
or HIGH LOW level ones. This last two are exclusive and
cannot be generated at the same time.
Hope this helps.
Thanks in advance.
Best regards,
Sergio Paracuellos
Sergio Paracuellos (8):
staging: mt7621-gpio: make use 'bgpio_init' from GPIO_GENERIC
staging: mt7621-gpio: avoid including 'gpio.h'
staging: mt7621-gpio: make use of 'builtin_platform_driver'
staging: mt7621-gpio: implement '.irq_[request|release]_resources'
functions
staging: mt7621-gpio: add COMPILE_TEST
staging: mt7621-gpio: add kerneldoc for state data containers
staging: mt7621-gpio: implement high level and low level irqs
staging: mt7621-gpio: avoid custom irq_domain for gpio
drivers/staging/mt7621-gpio/Kconfig | 4 +-
drivers/staging/mt7621-gpio/gpio-mt7621.c | 369 +++++++++++++-----------------
2 files changed, 168 insertions(+), 205 deletions(-)
--
2.7.4
More information about the devel
mailing list