[PATCH v2 00/18] staging: mt7621-pinctrl: some cleanups

Sergio Paracuellos sergio.paracuellos at gmail.com
Fri Jun 8 12:16:30 UTC 2018


This patch series make some cleanups for this driver:
 - different checkpatch issues
 - Avoid code duplication using some stuff from pinctrl utils
 - Some trivial refactors

Neil, I will send bindings documentation for this, but appart
of that it would be nice if you could point me out other
changes that could be performed to get this out of staging.

Hope this helps. Thanks in advance.

Changes in v2:
    - PATCH 7: use devm_kcalloc to indent properly when fixing line sizes
               and void the use of temporal 'size' variables.
    - PATCH 14: use 'group' binding instead of 'groups'
    - PATCH 15: use 'for_each_node_with_property' to count groups nodes.

    The rest of patches are the same.

Best regards,
    Sergio Paracuellos

Sergio Paracuellos (18):
  staging: mt7621-pinctrl: add SPDX identifier
  staging: mt7621-pinctrl: replace 'unsigned' types with 'unsigned int'
  staging: mt7621-pinctrl: remove unnecessary 'out of memory' message
  staging: mt7621-pinctrl: replace ENOSYS with better fitting error code
  staging: mt7621-pinctrl: avoid space after if condition
  staging: mt7621-pinctrl: add space in function call parameter list
  staging: mt7621-pinctrl: avoid lines over 80 chars
  staging: mt7621-pinctrl: replace seq_printf with seq_puts
  staging: mt7621-pinctrl: align function parameters in some functions
  staging: mt7621-pinctrl: use tabs instead of spaces in some
    indentations
  staging: mt7621-pinctrl: make use of pinctrl_utils_free_map
  staging: mt7621-pinctrl: replace uint8_t type with u8 for 'gpio' field
  staging: mt7621-pinctrl: make use of pinctrl_utils_reserve_map
  staging: mt7621-dts: use 'function' and 'group' for pinctrl bindings
  staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map
    function
  staging: mt7621-pinctrl: use ternary operator return in
    rt2880_get_group_name
  staging: mt7621-pinctrl: remove 'rt2880_pinctrl_pin_dbg_show' callback
  staging: mt7621-pinctrl: replace core_initcall_sync with
    module_platform_driver

 drivers/staging/mt7621-dts/mt7621.dtsi          |  48 +++---
 drivers/staging/mt7621-pinctrl/pinctrl-rt2880.c | 188 +++++++++---------------
 2 files changed, 93 insertions(+), 143 deletions(-)

-- 
2.7.4



More information about the devel mailing list