[PATCH] staging: comedi: quatech_daqp_cs: fix no-op loop daqp_ao_insn_write()

Ian Abbott abbotti at mev.co.uk
Tue Jun 5 10:06:59 UTC 2018


On 05/06/18 10:36, Dan Carpenter wrote:
> There is a '>' vs '<' typo so this loop is a no-op.
> 
> Fixes: d35dcc89fc93 ("staging: comedi: quatech_daqp_cs: fix daqp_ao_insn_write()")
> Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
> 
> diff --git a/drivers/staging/comedi/drivers/quatech_daqp_cs.c b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> index ea194aa01a64..257b0daff01f 100644
> --- a/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> +++ b/drivers/staging/comedi/drivers/quatech_daqp_cs.c
> @@ -642,7 +642,7 @@ static int daqp_ao_insn_write(struct comedi_device *dev,
>   	/* Make sure D/A update mode is direct update */
>   	outb(0, dev->iobase + DAQP_AUX_REG);
>   
> -	for (i = 0; i > insn->n; i++) {
> +	for (i = 0; i < insn->n; i++) {
>   		unsigned int val = data[i];
>   		int ret;
>   
> 

Thanks for catching that bug!

Reviewed-by: Ian Abbott <abbotti at mev.co.uk>

-- 
-=( Ian Abbott <abbotti at mev.co.uk> || Web: www.mev.co.uk )=-
-=( MEV Ltd. is a company registered in England & Wales. )=-
-=( Registered number: 02862268.  Registered address:    )=-
-=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-


More information about the devel mailing list