[PATCH 1/3] Fix checkpatch warnings in goldfish_audio.c

rkir at google.com rkir at google.com
Fri Jun 1 00:22:21 UTC 2018


From: Roman Kiryanov <rkir at google.com>

Address issues pointed by checkpatch.pl

Signed-off-by: Roman Kiryanov <rkir at google.com>
---
 drivers/staging/goldfish/goldfish_audio.c | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c
index bd559956f199..913c75645110 100644
--- a/drivers/staging/goldfish/goldfish_audio.c
+++ b/drivers/staging/goldfish/goldfish_audio.c
@@ -61,10 +61,11 @@ struct goldfish_audio {
 #define COMBINED_BUFFER_SIZE    ((2 * READ_BUFFER_SIZE) + \
 					(2 * WRITE_BUFFER_SIZE))
 
-#define AUDIO_READ(data, addr)		(readl(data->reg_base + addr))
-#define AUDIO_WRITE(data, addr, x)	(writel(x, data->reg_base + addr))
+#define AUDIO_READ(data, addr)		(readl((data)->reg_base + (addr)))
+#define AUDIO_WRITE(data, addr, x)	(writel(x, (data)->reg_base + (addr)))
 #define AUDIO_WRITE64(data, addr, addr2, x)	\
-	(gf_write_dma_addr((x), data->reg_base + addr, data->reg_base + addr2))
+	(gf_write_dma_addr((x), (data)->reg_base + (addr), \
+		(data)->reg_base + (addr2)))
 
 /*
  *  temporary variable used between goldfish_audio_probe() and
@@ -294,8 +295,11 @@ static int goldfish_audio_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "platform_get_irq failed\n");
 		return -ENODEV;
 	}
-	data->buffer_virt = dmam_alloc_coherent(&pdev->dev,
-				COMBINED_BUFFER_SIZE, &buf_addr, GFP_KERNEL);
+	data->buffer_virt =
+		dmam_alloc_coherent(&pdev->dev,
+				    COMBINED_BUFFER_SIZE,
+				    &buf_addr,
+				    GFP_KERNEL);
 	if (!data->buffer_virt) {
 		dev_err(&pdev->dev, "allocate buffer failed\n");
 		return -ENOMEM;
-- 
2.17.0.921.gf22659ad46-goog



More information about the devel mailing list