[PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

Greg Kroah-Hartman gregkh at linuxfoundation.org
Sat Jul 14 06:33:34 UTC 2018


On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor at google.com>
> 
> Return -ETIMEDOUT on timeouts.
> 
> Don't need 64-bit sized retry count.
> 
> Use msleep().
> 
> Return immediately when condition hit.

Huge hint, when you have to list the different things you do in a patch,
that means it should be split up into smaller patches.

Please rework this patch series based on this.  I'll stop reviewing them
now and wait for a new set of patches.

thanks,

greg k-h


More information about the devel mailing list