[PATCH 1/5] staging: gasket: remove pointless gasket_interrupt_pause()

Greg Kroah-Hartman gregkh at linuxfoundation.org
Fri Jul 13 10:05:51 UTC 2018


gasket_interrupt_pause() does nothing, and no one calls it, so remove it
as it is dead-weight.

Cc: Rob Springer <rspringer at google.com>
Cc: John Joseph <jnjoseph at google.com>
Cc: Ben Chan <benchan at chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/gasket/gasket_interrupt.c | 18 ------------------
 drivers/staging/gasket/gasket_interrupt.h | 11 -----------
 2 files changed, 29 deletions(-)

diff --git a/drivers/staging/gasket/gasket_interrupt.c b/drivers/staging/gasket/gasket_interrupt.c
index faaabdce4720..922ffd5836cd 100644
--- a/drivers/staging/gasket/gasket_interrupt.c
+++ b/drivers/staging/gasket/gasket_interrupt.c
@@ -426,24 +426,6 @@ static void gasket_interrupt_setup(struct gasket_dev *gasket_dev)
 }
 
 /* See gasket_interrupt.h for description. */
-void gasket_interrupt_pause(struct gasket_dev *gasket_dev, int enable_pause)
-{
-	WARN_ON(!gasket_dev);
-
-	if (!gasket_dev->interrupt_data)
-		return; /* nothing to do */
-
-	if (gasket_dev->interrupt_data->type == PCI_MSI ||
-	    gasket_dev->interrupt_data->type == PCI_MSIX) {
-		/* Nothing to be done for MSI/MSIX just yet. */
-	}
-
-	if (gasket_dev->interrupt_data->type == PLATFORM_WIRE) {
-		/* Nothing to be done for PLATFORM_WIRE */
-	}
-}
-EXPORT_SYMBOL(gasket_interrupt_pause);
-
 void gasket_interrupt_cleanup(struct gasket_dev *gasket_dev)
 {
 	struct gasket_interrupt_data *interrupt_data =
diff --git a/drivers/staging/gasket/gasket_interrupt.h b/drivers/staging/gasket/gasket_interrupt.h
index 44ea98570844..44ceedec52d8 100644
--- a/drivers/staging/gasket/gasket_interrupt.h
+++ b/drivers/staging/gasket/gasket_interrupt.h
@@ -150,15 +150,4 @@ struct eventfd_ctx **gasket_interrupt_get_eventfd_ctxs(
 
 int gasket_interrupt_system_status(struct gasket_dev *gasket_dev);
 
-/*
- * Masks interrupts and de-register the handler.
- * After an interrupt pause it is not guaranteed that the chip registers will
- * be accessible anymore, since the chip may be in a power save mode,
- * which means that the interrupt handler (if it were to happen) may not
- * have a way to clear the interrupt condition.
- * @gasket_dev: The Gasket device struct
- * @enable_pause: Whether to pause or unpause the interrupts.
- */
-void gasket_interrupt_pause(struct gasket_dev *gasket_dev, int enable_pause);
-
 #endif
-- 
2.18.0



More information about the devel mailing list