[PATCH] Staging: Gasket: uninitialized return in gasket_mmap()
Dan Carpenter
dan.carpenter at oracle.com
Fri Jul 6 08:37:56 UTC 2018
We forgot to set the error code on this error path so ret can be
uninitialized.
Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
index 6511a33eb658..1f43c739a9ed 100644
--- a/drivers/staging/gasket/gasket_core.c
+++ b/drivers/staging/gasket/gasket_core.c
@@ -1719,8 +1719,10 @@ static int gasket_mmap(struct file *filp, struct vm_area_struct *vma)
/* Try the next region if this one was not mappable. */
if (map_status == DO_MAP_REGION_INVALID)
continue;
- if (map_status == DO_MAP_REGION_FAILURE)
+ if (map_status == DO_MAP_REGION_FAILURE) {
+ ret = -ENOMEM;
goto fail;
+ }
has_mapped_anything = 1;
}
More information about the devel
mailing list