[PATCH v2 00/14] fix to remove unnecessary parenthesis,typedef and avoid camelCase

Claudiu Beznea Claudiu.Beznea at microchip.com
Mon Jan 22 11:54:14 UTC 2018


My comments to this series were only notes to be taken
into account for future patches.

Thank you,
Claudiu Beznea

On 22.01.2018 12:22, Ajay Singh wrote:
> This patch series contains changes to fix issues reported by checkpatch.pl script.
> 
> Changes since v1:
> * Patch0004: Used "host_int_parse_join_bss_param" for function name.
> * Patch0009: Put memcpy statement in single line instead of using two lines.
> * Patch0010: Used "bss_param" for variable name instead of j_bss_param.
> * Added "Reviewed-by: Claudiu Beznea <claudiu.beznea at microchip.com>" for commit description.
> * Modify the commit description to start with capital letter for all patch.
> 
> 
> Ajay Singh (14):
>   staging: wilc1000: remove unnecessary use of parentheses
>   staging: wilc1000: removed unnecessary defined enums typedef
>   staging: wilc1000: fix alignments to match open parenthesis
>   staging: wilc1000: rename host_int_ParseJoinBssParam() and it's
>     variable using camelCase
>   staging: wilc1000: rename camelCase used in Handle_DelAllSta() and its
>     variable
>   staging: wilc1000: rename strWIDList variable to wid_list to avoid
>     camelCase
>   staging: wilc1000: rename u32WidsCount variable to avoid camelCase
>   staging: wilc1000: rename pu8CurrByte variable to avoid camelCase
>   staging: wilc1000: rename pstrHostIFconnectAttr argument to avoid
>     camelCase
>   staging: wilc1000: rename ptstrJoinBssParam variable to avoid
>     camelCase
>   staging: wilc1000: rename strConnectInfo variable to avoid camelCase
>   staging: wilc1000: rename Handle_ScanDone() to avoid camelCase
>   staging: wilc1000: rename Handle_Connect() to avoid camelCase
>   staging: wilc1000: rename Handle_ConnectTimeout() and Handle_Key()
> 
>  drivers/staging/wilc1000/coreconfigurator.c       |   2 +-
>  drivers/staging/wilc1000/host_interface.c         | 937 +++++++++++-----------
>  drivers/staging/wilc1000/linux_wlan.c             |  10 +-
>  drivers/staging/wilc1000/wilc_sdio.c              |   4 +-
>  drivers/staging/wilc1000/wilc_spi.c               |  20 +-
>  drivers/staging/wilc1000/wilc_wfi_cfgoperations.c |  64 +-
>  drivers/staging/wilc1000/wilc_wlan.c              |   2 +-
>  drivers/staging/wilc1000/wilc_wlan_cfg.c          |   6 +-
>  drivers/staging/wilc1000/wilc_wlan_if.h           |  72 +-
>  9 files changed, 555 insertions(+), 562 deletions(-)
> 


More information about the devel mailing list