[PATCH] staging: unisys: change select to depends for subsystems

Randy Dunlap rdunlap at infradead.org
Mon Jan 15 05:10:54 UTC 2018


From: Randy Dunlap <rdunlap at infradead.org>

Drivers should not 'select' a subsystem. Instead they should depend
on it. If the subsystem is disabled, the user probably did that for
a purpose and one driver shouldn't be changing that.

Signed-off-by: Randy Dunlap <rdunlap at infradead.org>
Cc: David Kershner <david.kershner at unisys.com>
Cc: sparmaintainer at unisys.com (Unisys internal)
Cc: devel at driverdev.osuosl.org
Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
---
 drivers/staging/unisys/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- lnx-415-rc8.orig/drivers/staging/unisys/Kconfig
+++ lnx-415-rc8/drivers/staging/unisys/Kconfig
@@ -4,8 +4,7 @@
 menuconfig UNISYSSPAR
 	bool "Unisys SPAR driver support"
 	depends on X86_64 && !UML
-	select PCI
-	select ACPI
+	depends on PCI && ACPI
 	---help---
 	Support for the Unisys SPAR drivers
 


More information about the devel mailing list