[PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

Dan Carpenter dan.carpenter at oracle.com
Fri Jan 12 13:45:43 UTC 2018


On Fri, Jan 12, 2018 at 06:39:22AM -0700, Kenny Ballou wrote:
> 
> On 2018年01月12日 13:21 GMT, Dan Carpenter wrote:
> > On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote:
> >> >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short ModeIdIndex,
> >> >>  	tempax |= tempcx;
> >> >>
> >> >>  	xgifb_reg_set(pVBInfo->Part1Port, 0x15, tempax);
> >> >> -	xgifb_reg_set(pVBInfo->Part1Port, 0x14,
> >> >> +	xgifb_reg_set(pVBInfo->Part1Port,
> >> >> +		      0x14,
> >> >>  		      (unsigned short)(tempbx & 0xff));
> >> >>
> >> >>  	tempax = pVBInfo->VT;
> >> >
> >> > I just don't understand why you're doing this...
> >> >
> >>
> >> This was mainly to fix checkpatch warnings about line length.  If it's
> >> preferred to not fix these, I will change the patch.
> >
> >
> > There is probably a checkpatch warning about CamelCase?  It's not over
> > 80 characters.
> 
> Correct, there are many in this driver.  However, as a new submitter, I
> was specifically choosing warnings over "checks" as I wasn't sure what
> the preferred resolution is for "checks" and specifically CamelCase
> issues.  Moreover, CamelCase fixes are arguably a different patch, no?
> Possibly part of the series, but a different patch nonetheless.

We seem to be talking at cross purposes.  Yes, CamelCase is a different
patch.  I was just trying to guess where you went wrong.  You are
sending a patch that "fixes long line warnings" but:

	xgifb_reg_set(pVBInfo->Part1Port, 0x14,

This is a short line...  Anyway, try to resend it and hopefully it will
be better in v2.

regards,
dan carpenter



More information about the devel mailing list