[PATCH v2 2/3] staging: xgifb: vb_setmode: fix 80 char lines

Dan Carpenter dan.carpenter at oracle.com
Fri Jan 12 13:21:38 UTC 2018


On Fri, Jan 12, 2018 at 06:10:17AM -0700, Kenny Ballou wrote:
> >> @@ -1468,7 +1472,8 @@ static void XGI_SetLVDSRegs(unsigned short ModeIdIndex,
> >>  	tempax |= tempcx;
> >>
> >>  	xgifb_reg_set(pVBInfo->Part1Port, 0x15, tempax);
> >> -	xgifb_reg_set(pVBInfo->Part1Port, 0x14,
> >> +	xgifb_reg_set(pVBInfo->Part1Port,
> >> +		      0x14,
> >>  		      (unsigned short)(tempbx & 0xff));
> >>
> >>  	tempax = pVBInfo->VT;
> >
> > I just don't understand why you're doing this...
> >
> 
> This was mainly to fix checkpatch warnings about line length.  If it's
> preferred to not fix these, I will change the patch.


There is probably a checkpatch warning about CamelCase?  It's not over
80 characters.

regards,
dan carpenter



More information about the devel mailing list