[PATCH 8/8] staging: wilc1000: fix open parenthesis mismatch issue in wilc_wlan_cfg_set()
Dan Carpenter
dan.carpenter at oracle.com
Tue Feb 27 09:41:40 UTC 2018
The first 5 patches are good, but the last 3 are not OK.
Normally "tmp" is used as an iterator pointer or something along those
lines. For example, here is a good use of "tmp".
tmp = left;
left = right;
right = tmp;
In this example, you want to store a pointer temporarily, so what else
are you going to call it besides "tmp"? The name "tmp" doesn't mean
"I want a short name and I'm too lazy to think of one".
regards,
dan carpenter
More information about the devel
mailing list