[PATCH] Staging: ks7010: Fix Unnecessary parentheses in ks_hostif.c

Greg KH gregkh at linuxfoundation.org
Sat Feb 17 12:12:02 UTC 2018


On Sat, Feb 17, 2018 at 12:58:46PM +0530, Yash Omer wrote:
> This patch fixes up unnecessary parenthesis issue found by checkpatch.pl
> 
> Signed-off-by: Yash Omer <yashomer0007 at gmail.com>
> ---
>  drivers/staging/ks7010/ks_hostif.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/ks7010/ks_hostif.c b/drivers/staging/ks7010/ks_hostif.c
> index 975dbbb3abd0..7bd567e233d7 100644
> --- a/drivers/staging/ks7010/ks_hostif.c
> +++ b/drivers/staging/ks7010/ks_hostif.c
> @@ -850,7 +850,7 @@ void hostif_scan_indication(struct ks_wlan_private *priv)
>  		DPRINTK(4, " scan_ind_count=%d :: aplist.size=%d\n",
>  			priv->scan_ind_count, priv->aplist.size);
>  		get_ap_information(priv, (struct ap_info_t *)(priv->rxp),
> -				   &(priv->aplist.ap[priv->scan_ind_count - 1]));
> +				   &(priv->aplist.ap priv->scan_ind_count - 1));

Did you actually compile this?

Please, step back and go learn the C language first really really well.
The change you made here is obviously not correct at all.

I suggest you work on userspace programs first for a few years before
working on the kernel, it is not a place to learn how to program.

good luck!

greg k-h


More information about the devel mailing list