[PATCH] Resolve RF Type mismatch

Dan Carpenter dan.carpenter at oracle.com
Wed Feb 7 10:51:11 UTC 2018


On Wed, Feb 07, 2018 at 12:57:13AM +0900, Kangmin Park wrote:
> From: pr0gr4m <l4stpr0gr4m at gmail.com>

No changelog, no sign-off.  Changelogs are required but especially in
this case, it's not immediately obvious what this patch is about.

This patch has unrelated white space changes as well.  Here is how the
rules work:

> -	ODM_1T1R	=	0,
> +	ODM_1T1R		=	0,

This are unrelated.

This white space change is on the same line so that's fine (it's
related).

> -	else if ((rf_type == RF_1T2R) || (rf_type ==RF_2T2R))
> +	else if ((rf_type == RF_1T2R) || (rf_type == RF_2T2R) || (rf_type == RF_2T2R_GREEN))

regards,
dan carpenter



More information about the devel mailing list