[PATCH 15/18] staging: mt7621-pinctrl: refactor rt2880_pinctrl_dt_node_to_map function

NeilBrown neil at brown.name
Sun Dec 30 08:28:42 UTC 2018


On Sun, Dec 30 2018, Sergio Paracuellos wrote:

> Hi again and sorry for the noise.

A bit of noise is no problem, especially when it leads to the right
answer.

>
> +       *num_maps = 0;

Yes, this works.
I had tried other numbers like ngroups, and got strange errors.
With this, it all works.

>
> Looking other drivers and 'pinctrl_utils_reserve_map' code it seems
> this should be first set to zero.

Yes, I can see that now in pinconf_generic_dt_node_to_map() which is a
lot of driver use ... I wonder if we can use the 'generic' one too.

Anyway,
  Reported-and-tested-by: NeilBrown <neil at brown.name>

for the addition of
  *num_maps = 0;

Thanks!
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20181230/22bb9e65/attachment-0001.asc>


More information about the devel mailing list