[PATCH] staging:iio:adc: fix codestyle

Dan Carpenter dan.carpenter at oracle.com
Mon Dec 17 07:45:41 UTC 2018


The patch prefix should be "staging: iio: adc: ad7280a:".  Do
git log --oneline drivers/staging/iio/adc/ad7280a.c and copy what
other people do.

On Mon, Dec 17, 2018 at 04:43:33AM +0300, Sergey Efimochkin wrote:
> staging:iio:adc: fix codestyle

Only to do one thing per patch.  We need a better patch description.

> Signed-off-by: Sergey Efimochkin <efimochkin.sv at phystech.edu>
> ---
>  drivers/staging/iio/adc/ad7280a.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 58420dcb406d..52e12d1201b3 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -706,8 +706,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>  				st->cell_threshhigh)
>  				iio_push_event(indio_dev,
>  					       IIO_EVENT_CODE(IIO_VOLTAGE,
> -							1,
> -							0,
> +							      1,
> +							      0,
>  							IIO_EV_DIR_RISING,
>  							IIO_EV_TYPE_THRESH,
>  							0, 0, 0),

No.  Now the IIO_EV_DIR_RISING, and later columns are not aligned
correctly.  Just ignore the checkpatch warning.  It's fine as-is.

> @@ -987,6 +985,6 @@ static struct spi_driver ad7280_driver = {
>  };
>  module_spi_driver(ad7280_driver);
>  
> -MODULE_AUTHOR("Michael Hennerich <michael.hennerich at analog.com>");
> +MODULE_AUTHOR("Michael Hennerich <hennerich at blackfin.uclinux.org>");

This change needs to come from Michael.  Just leave the code as-is.

regards,
dan carpenter



More information about the devel mailing list