[PATCH net-next 7/8] net: core: dev: Attach extack to NETDEV_PRE_UP

David Ahern dsa at cumulusnetworks.com
Wed Dec 5 16:44:37 UTC 2018


On 12/5/18 3:52 AM, Petr Machata wrote:
> Drivers may need to validate configuration of a device that's about to
> be upped. Should the validation fail, there's currently no way to
> communicate details of the failure to the user, beyond an error number.
> 
> To mend that, change __dev_open() to take an extack argument and pass it
> from __dev_change_flags() and dev_open(), where it was propagated in the
> previous patches.
> 
> Change __dev_open() to call call_netdevice_notifiers_extack() so that
> the passed-in extack is attached to the NETDEV_PRE_UP notifier.
> 
> Signed-off-by: Petr Machata <petrm at mellanox.com>
> Acked-by: Jiri Pirko <jiri at mellanox.com>
> Reviewed-by: Ido Schimmel <idosch at mellanox.com>
> ---
>  net/core/dev.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 

Reviewed-by: David Ahern <dsahern at gmail.com>




More information about the devel mailing list