[PATCH] Staging: One Laptop Per Child: add function argument names

Arkadiusz Lis areklis909 at gmail.com
Tue Aug 28 19:34:57 UTC 2018


On Mon, Aug 27, 2018 at 07:52:13PM +0200, Greg KH wrote:
> On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote:
> > Add function argument names to pointers to functions
> > in struct dcon_platform_data: init, set_dconload and read_status
> > This commit removes checkpatch.pl warning.
> > 
> > Signed-off-by: Arkadiusz Lis <areklis909 at gmail.com>
> > ---
> >  drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
> > index fa89bb9..0ce1a7a 100644
> > --- a/drivers/staging/olpc_dcon/olpc_dcon.h
> > +++ b/drivers/staging/olpc_dcon/olpc_dcon.h
> > @@ -91,10 +91,10 @@ struct dcon_priv {
> >  };
> >  
> >  struct dcon_platform_data {
> > -	int (*init)(struct dcon_priv *);
> > +	int (*init)(struct dcon_priv *dcon);
> >  	void (*bus_stabilize_wiggle)(void);
> > -	void (*set_dconload)(int);
> > -	int (*read_status)(u8 *);
> > +	void (*set_dconload)(int val);
> > +	int (*read_status)(u8 *status);
> >  };
> >  
> >  #include <linux/interrupt.h>
> > -- 
> > 1.9.1
> > 
> > _______________________________________________
> > devel mailing list
> > devel at linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
> 
> Patch did not apply to my tree at all.  Please rebase against the latest
> linux-next and resend.
> 
> thanks,
> 
> greg k-h

Hi Greg,
It seems this issue was already fixed with commit 9b59883c14267ccf2c3f9d260bd6fb0dc9478fa1, hence the conflict.
My patch is redundant

Regards,
Arek


More information about the devel mailing list