[PATCH v4 2/4] staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages

Nishad Kamdar nishadkamdar at gmail.com
Thu Aug 23 17:15:58 UTC 2018


On Wed, Aug 22, 2018 at 12:13:42PM +0300, Dan Carpenter wrote:
> On Wed, Aug 22, 2018 at 02:13:07PM +0530, Nishad Kamdar wrote:
> > diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c
> > index 04d23cc7cd4a..6b2c72fc61f2 100644
> > --- a/drivers/staging/mt7621-mmc/sd.c
> > +++ b/drivers/staging/mt7621-mmc/sd.c
> > @@ -466,7 +466,8 @@ static void msdc_set_mclk(struct msdc_host *host, int ddr, unsigned int hz)
> >  	//u8  clksrc = hw->clk_src;
> >  
> >  	if (!hz) { // set mmc system clock to 0 ?
> > -		//ERR_MSG("set mclk to 0!!!");
> > +		//dev_err(mmc_dev(host->mmc), "%d -> set mclk to 0!!!\n",
> > +		//	  host->id);
> 
> Just delete commented out code.
> 
> >  		msdc_reset_hw(host);
> >  		return;
> >  	}
> 
> regards,
> dan carpenter
> 

Ok, I'll do that.

Thanks for the review.

regards,
nishad


More information about the devel mailing list