[PATCH v4 0/4] Fix debug macros and their usages

Nishad Kamdar nishadkamdar at gmail.com
Wed Aug 22 08:33:02 UTC 2018


This patchset fixes the four debug macros N_MSG, ERR_MSG, INIT_MSG and
IRQ_MSG. Each patch fixes one particular macro and its usages.

For N_MSG, replaces printk with dev_<level> without __func__ or __LINE__
or current->comm and current->pid. Removes the do {} while(0) loop for
the single statement macro.

For ERR_MSG and IRQ_MSG, makes the same changes as those for N_MSG, but
further drops the macros and replaces their usages with dev_<level>.

Removes the INIT_MSG macro and its usages.

Changes in v4:
  - Create multiple patches, one for each type of macro being
    deleted/changed.

Changes in v3:
  - Replace usages of ERR_MSG and IRQ_MSG with dev_err() in code itself.
  - Remove all INIT_MSG usages.
  - Drop ERR_MSG, INIT_MSG and IRQ_MSG from dbg.h.

Changes in v2:
  - Replace printk with dev_<level>.
  - Remove __func__, __LINE__, current->comm, current->pid from arguments.
  - Remove the do {} while(0) loop from these macros.
  - Modify commit message to include other changes.
-
Nishad Kamdar (4):
  staging: mt7621-mmc: Fix debug macro N_MSG
  staging: mt7621-mmc: Fix debug macro ERR_MSG and its usages
  staging: mt7621-mmc: Remove macro INIT_MSG and its usages
  staging: mt7621-mmc: Fix debug macro IRQ_MSG and its usages

 drivers/staging/mt7621-mmc/dbg.h |  36 +------
 drivers/staging/mt7621-mmc/sd.c  | 180 ++++++++++++++++++++-----------
 2 files changed, 121 insertions(+), 95 deletions(-)

-- 
2.17.1



More information about the devel mailing list