[PATCH 1/2] staging: fix possible_condition_with_no_effect warnings

Larry Finger Larry.Finger at lwfinger.net
Sun Aug 5 20:36:01 UTC 2018


On 08/05/2018 02:35 PM, Umang Parmar wrote:
> Remove unnecessary conditions where if and else block had same code.
> Signed-off-by: Umang Parmar <umangjparmar at gmail.com>

The subject should be "staging: rtlwifi: ...". If someone wants to search for 
fixes to the modules in drivers/staging/rtlwifi/, your subject would not be helpful.
> ---
>   .../rtlwifi/btcoexist/halbtc8822b2ant.c       |  6 ----
>   .../staging/rtlwifi/btcoexist/halbtcoutsrc.c  |  6 ++--
>   drivers/staging/rtlwifi/phydm/phydm_debug.c   | 29 ++++++-------------
>   drivers/staging/rtlwifi/phydm/phydm_dig.c     | 10 ++-----
>   .../staging/rtlwifi/phydm/phydm_hwconfig.c    |  4 +--
>   drivers/staging/rtlwifi/phydm/phydm_psd.c     |  7 +----
>   6 files changed, 16 insertions(+), 46 deletions(-)

Why do some of the above have "drivers/staging/..." and others have 
".../staging/..."? This looks a bit strange.

Otherwise, this patch looks OK.

Larry


More information about the devel mailing list