[PATCH] staging: lustre: Change return type to vm_fault_t

[Matthew Wilcox]

On Mon, Apr 23, 2018 at 10:12:30PM +0530, Souptick Joarder wrote:
> On Sun, Apr 22, 2018 at 8:50 AM, Matthew Wilcox <willy at infradead.org> wrote:
> > On Sun, Apr 22, 2018 at 03:47:24AM +0530, Souptick Joarder wrote:
> >> @@ -261,7 +261,7 @@ static inline int to_fault_error(int result)
> >>   * \retval VM_FAULT_ERROR on general error
> >>   * \retval NOPAGE_OOM not have memory for allocate new page
> >>   */
> >> -static int ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> >> +static vm_fault_t ll_fault0(struct vm_area_struct *vma, struct vm_fault *vmf)
> >>  {
> >>       struct lu_env      *env;
> >>       struct cl_io        *io;
> >
> > Did you compile-test this with the sparse changes?  Because I can see
> > a problem here:
> 
> Yes, compile-tested. Sparse didn't throw any warning/error.

I think you need to check your setup ... I get this:

drivers/staging/lustre/lustre/llite/llite_mmap.c:277:31: warning: incorrect type in return expression (different base types)
drivers/staging/lustre/lustre/llite/llite_mmap.c:277:31:    expected restricted vm_fault_t
drivers/staging/lustre/lustre/llite/llite_mmap.c:277:31:    got long