[PATCH 00/31] staging: mt7621-mmc: Next cleanups

NeilBrown neil at brown.name
Fri Apr 20 22:44:39 UTC 2018


On Wed, Apr 18 2018, Christian Lütke-Stetzkamp wrote:

> Here are the next cleanups for the mt7621-mmc driver. Most of them
> just remove some unused code, but there are also some other cleanups
> and fixes. This also changes the default to always using DMA for data
> transfer, if there are no performance issues with that, the non-DMA
> code will be removed in the future, because the mtk-sd driver is also
> always using DMA.
>
> Christian Lütke-Stetzkamp (31):
>   staging: mt7621-mmc: Remove unused code from board.h
>   staging: mt7621-mmc: Remove unused field get_cd_status from msdc_hw
>   staging: mt7621-mmc: Remove unused field enable_cd_eirq from msdc_hw
>   staging: mt7621-mmc: Remove unused field disable_cd_eirq
>   staging: mt7621-mmc: Fix null pointer deref if ext sdio irq enabled
>   staging: mt7621-mmc: Remove power callbacks from msdc_hw
>   staging: mt7621-mmc: Refactor and rename msdc_reset to msdc_reset_hw
>   staging: mt7621-mmc: Remove code for not existent config
>   staging: mt7621-mmc: Relax cpu while waiting for stable clock
>   staging: mt7621-mmc: Remove unused field data_offset from msdc_hw
>   staging: mt7621-mmc: Remove multiple assignments

Apart from this patch which I commented on separately, and...

>   staging: mt7621-mmc: Remove unused field burstsz from msdc_dma
>   staging: mt7621-mmc: Remove unused function msdc_dma_dump
>   staging: mt7621-mmc: Start cleanup of msdc_dma_config
>   staging: mt7621-mmc: Remove unused fields from msdc_dma
>   staging: mt7621-mmc: Remove flags from msdc_dma
>   staging: mt7621-mmc: Remove unused field xfersz from msdc_dma
>   staging: mt7621-mmc: Fix dma_map_sg may map to fever entries

...this patch - I don't want fever entries in the kernel, but fewer
entries would be fine :-)

They all get
  Reviewed-by: NeilBrown <neil at brown.com>

(and the other two get that as well if you make the changes I
suggested).

Thanks,
NeilBrown



>   staging: mt7621-mmc: Replace dma dir with mmc_get_dma_dir
>   staging: mt7621-mmc: Correct datatypes for io and sanitize io access
>   staging: mt7621-mmc: Add annotations about held locks
>   staging: mt7621-mmc: Refactor msdc_init_gpd_bd
>   staging: mt7621-mmc: Remove old references to tasklet
>   staging: mt7621-mmc: Change default transfer mode to DMA
>   staging: mt7621-mmc: Remove unused field starttime from msdc_host
>   staging: mt7621:mmc: Remove unused field reserved from msdc_host
>   staging: mt7621-mmc: Remove unused field dma_left_size of msdc_host
>   staging: mt7621-mmc: Remove unused card_workqueue from msdc_host
>   staging: mt7621-mmc: Remove unused field cmd_r1b_done in msdc_host
>   staging: mt7621-mmc: Remove unused field cmd_rsp_done of msdc_host
>   staging: mt7621-mmc: Remove unused field dma_addr of msdc_host
>
>  drivers/staging/mt7621-mmc/board.h     |  64 ------
>  drivers/staging/mt7621-mmc/dbg.c       |   8 +-
>  drivers/staging/mt7621-mmc/mt6575_sd.h |  69 ++----
>  drivers/staging/mt7621-mmc/sd.c        | 404 +++++++++++----------------------
>  4 files changed, 154 insertions(+), 391 deletions(-)
>
> -- 
> 2.16.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180421/170947b7/attachment.asc>


More information about the devel mailing list