[PATCH] staging: mt7621-gpio: prefer unsigned int to bare unsigned

NeilBrown neil at brown.name
Wed Apr 4 22:49:21 UTC 2018


On Mon, Apr 02 2018, Sergio Paracuellos wrote:

> This commit replaces some bare unsigned definitions in some
> function parameters in favour of 'unsigned int' which is
> preferred.
>
> This also fix checkpatch warnings about this.
>
> Signed-off-by: Sergio Paracuellos <sergio.paracuellos at gmail.com>

Reviewed-by: NeilBrown <neil at brown.name>

Thanks,
NeilBrown


> ---
>  drivers/staging/mt7621-gpio/gpio-mt7621.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/staging/mt7621-gpio/gpio-mt7621.c b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> index 5123568..66fdb59 100644
> --- a/drivers/staging/mt7621-gpio/gpio-mt7621.c
> +++ b/drivers/staging/mt7621-gpio/gpio-mt7621.c
> @@ -69,7 +69,7 @@ mtk_gpio_r32(struct mtk_gc *rg, u8 reg)
>  }
>  
>  static void
> -mediatek_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
> +mediatek_gpio_set(struct gpio_chip *chip, unsigned int offset, int value)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  
> @@ -77,7 +77,7 @@ mediatek_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
>  }
>  
>  static int
> -mediatek_gpio_get(struct gpio_chip *chip, unsigned offset)
> +mediatek_gpio_get(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  
> @@ -85,7 +85,7 @@ mediatek_gpio_get(struct gpio_chip *chip, unsigned offset)
>  }
>  
>  static int
> -mediatek_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
> +mediatek_gpio_direction_input(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  	unsigned long flags;
> @@ -102,7 +102,7 @@ mediatek_gpio_direction_input(struct gpio_chip *chip, unsigned offset)
>  
>  static int
>  mediatek_gpio_direction_output(struct gpio_chip *chip,
> -					unsigned offset, int value)
> +					unsigned int offset, int value)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  	unsigned long flags;
> @@ -119,7 +119,7 @@ mediatek_gpio_direction_output(struct gpio_chip *chip,
>  }
>  
>  static int
> -mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
> +mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned int offset)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  	unsigned long flags;
> @@ -136,7 +136,7 @@ mediatek_gpio_get_direction(struct gpio_chip *chip, unsigned offset)
>  }
>  
>  static int
> -mediatek_gpio_to_irq(struct gpio_chip *chip, unsigned pin)
> +mediatek_gpio_to_irq(struct gpio_chip *chip, unsigned int pin)
>  {
>  	struct mtk_gc *rg = to_mediatek_gpio(chip);
>  
> -- 
> 2.7.4
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180405/3a956cd9/attachment.asc>


More information about the devel mailing list