[PATCH v2 00/34] staging: mt7621-mmc: First cleanups

[NeilBrown]

On Thu, Apr 05 2018, Christian Lütke-Stetzkamp wrote:

> On Thu, Apr 05, 2018 at 08:06:47AM +1000, NeilBrown wrote:
>> On Wed, Apr 04 2018, Christian Lütke-Stetzkamp wrote:
>> 
>> > This patch series does the first cleanups in this driver. At some
>> > points I already tried to get the code of this driver as near as
>> > possible to the mk-sd driver in mainline.
>> >
>> > Changes in v2:
>> > * fix typos
>> > * Clearify comment regarding request irq
>> 
>> Thanks,
>>  It compiles and works for me, and the patches look good.
>> 
>>  Reviewed-by: NeilBrown <neil at brown.name>
>
> Thanks for your fast review!
>
>> There are two new warnings as msdc_eirq_cd and msdc_eirq_sdio are now
>> unused.  I think they should be discarded - they don't contain any
>> insights into how the hardware might work, and they are clearly untested
>> so possibly buggy.
>
> I'm already preparing a new series and have mad a patch to remove
> them, will send the next series once this is merged and a few new
> patches have accumulated.
>
> Could you please send me the configuration your are using to build the
> kernel for the GNUBEE? And have you ever tried to enable power
> management (CONFIG_PM)?

.config attached.

I think I did experiment with CONFIG_PM once a while ago and something
went horribly wrong, though I remember no details.  I had plenty of
other things to think about at the time so I just reverted and forgot
about it.

Thanks,
NeilBrown


>
> Thanks,
> Christian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180405/6d50abbd/attachment-0001.asc>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config
Type: application/x-config
Size: 95096 bytes
Desc: not available
URL: <http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/attachments/20180405/6d50abbd/attachment-0001.bin>